Looks like this is the cause: https://github.com/archivesspace/archivesspace/commit/7459536bc78e3017ef4b754a0e3b1369406a0164#diff-089a949d82ba05b235926e101e879d45R90

But not only does that remove the ability to do phrase searches, it also removes the ability to do wildcard searching with the asterisk, etc.

@Christine Di Bella, @Laney McGlohon: for testing, you'd just need to have a scope and content note added to an archival object that's over 500 characters, with something like a <title render="italic"> element wrapped around the entirety of the note.

But I can confirm that this particular issue is fixed in our instance of DEV right now. yay! there are a couple of downsides of stripping the HTML elements outright, though: 1) no formatting / links, but that's fine, in my opinion; 2) it can present spacing problems, which I think could be addressed by updating how those notes are presented. But if there was supposed to be a paragraph break or line break, for example, then those elements are pushed together (e.g. "Summary (English)Film"). it'd be nice if a space could be added in these instances; e.g. "Summary (English) Film". Missing the space is better than breaking whole page and having the facets pushed to the bottom, but it seems like this could be addressed with just a bit more logic inserted into the process.

However, I noticed a new problem in our instance of DEV (version 20171105-1021), which doesn't happen in our instance of TEST (version 2.1.2)... and I just checked 2.2.0 and that's okay, as well (phew!). Putting quotes around your query to initiate a phrase search does not work anymore. Not sure what commit caused this issue, but that will definitely need to be addressed.

Example: if I search for "statistically improbable phrase" in our corpus (without quotes), i get 76 results. if i search for the same query, but with quotes, i get the same 76 results. but i should get 0 results when i apply the quotes! and if i do that search in 2.1.2 (or 2.2), i get 0 results with our corpus, as expected.

@Mark Custer - the fix for this one was merged into master last week but it's hard to test since it only shows itself under very particular conditions. Since you have a dev server running that code, have you been able to note whether the problem record(s) look right in the PUI now?

A complete aside, but the following screenshot is one of the best examples of auto-generated ASpace art that I've seen yet:

@Cory Nimer how i wish i would've seen your super helpful note yesterday! in any event, it's also good to arrive at the same conclusion.

Here's my quick fix: Change line https://github.com/archivesspace/archivesspace/blob/master/public/app/views/shared/_result.html.erb#L23 to

Doing so will remove all HTML from the truncated notes in this view, but it will ensure that the resulting HTML of the overall page is valid, so that the results won't appear nested, and the facets won't be pushed into a completely different section of the page.