EAD export doesn't escape ampersands in notes with <p> tags
Description
The escape_content function, which cleans up bare ampersands for export is called from inside handle_linebreaks, which explicitly doesn't deal with content that has embedded <p> tags. See here. It seems that we should treat ampersands in notes the same way, whether or not there are <p> tags.
Environment
None
Activity
Show:
Daniel MichelsonFebruary 13, 2023 at 7:01 PM
At the February 7, 2023 meeting of Dev/Pri, we decided to close this ticket, since there are no known problems caused by this and changing it could have unforeseen consequences.
Donald SmithDecember 8, 2022 at 4:13 PM
Edited
It’s actually just ignoring content that starts with a <p> tag (and that regular expression looks a bit off to me), but I’m not sure that makes any more sense. It seems like this was intentional based on the comment in the code, but there’s no obvious reasoning for it that I can see in the commit that added it.
The escape_content function, which cleans up bare ampersands for export is called from inside handle_linebreaks, which explicitly doesn't deal with content that has embedded <p> tags. See here. It seems that we should treat ampersands in notes the same way, whether or not there are <p> tags.