's additional updates to this have been merged.

Confirming Bri’s results, the PUI did not return results when searching for specific terms in unpublished notes. Hopefully Andrew’s issues can also be addressed in a future development.

I have observed the following side-effects:

• Archival objects match keywords in their parent resource when searching in the PUI. That is because the PUI indexer retrieves ancestors in order to do inheritance of selected fields, but all the fields in those ancestors are now being included in the new “fullrecord_published” index.

• Indexing is slower, because each record is being scanned for fields to include in the new “fullrecord_published” and “notes_published” indexes. It only adds hundredths of a second per record, but for very large institutions that could add hours to a full re-index.

I have created a pull request with a possible approach to fixing these issues:

Tested and can confirm that a search through notes in the PUI does not return unpublished note contents or references to the resources they are within.

This PR made some changes to Solr search, so we should test that well to make sure it didn’t have any unintended consequences.