Issues

Select view

Select search mode

 
28 of 28

Cookie secrets AppConfig keys in launcher.rb are messed up

Done

Description

Scenario: I'm trying to set AppConfig[:frontend_cookie_secret] (and AppConfig[ublic_cookie_secret]) to a fixed value. Part of horizonally scaling frontend and public in a Kubernetes deployment.

In launcher.rb L148-152, the code is looking for AppConfig[:frontend_cookie_secret_cookie_secret], which doesn't and shouldn't exist, thus ignoring my defined AppConfig[:frontend_cookie_secret] and generating a random different cookie secret for each frontend instance.

(this would also be why the files in /data/ in a stock install are always named things like frontend_cookie_secret_cookie_secret.dat.)

Depending on which direction one fixed this, one might also touch generate_secret_for() in launcher.rb

I have a patch in my Docker build for this. I can easily make that a pull request, but I (think) I don't yet have an institutional contrib agreement (shakes head).

Environment

None

Details

Assignee

Reporter

Fix versions

Affects versions

Priority

Harvest Time Tracking

Open Harvest Time Tracking

Created March 20, 2019 at 3:14 PM
Updated February 24, 2020 at 1:44 PM
Resolved February 24, 2020 at 1:44 PM

Activity

Show:

Laney McGlohonNovember 11, 2019 at 3:10 PM

Thanks for the pull request! I have added you to the developers group in Jira and look forward to future contributions!

Thomas ShorockNovember 9, 2019 at 2:44 AM

Merged with

Laney McGlohonApril 11, 2019 at 12:47 PM

A pull request would be great! I will contact you separately by email about the contributor agreement.

Harvest Time Tracking