/
Pull Request Process

Pull Request Process

Sept 11, 2017

When people put in a pull request, the assumption is that the submitter believes they have done all that is required to fix or implement the issue.

So, when reviewing a pull request, these are the steps to take:

  • Review the issue being fixed to make sure you understand what is being worked on. When reviewing a pull request, please take the time to review the changes and get a sense of what is being changed. If you need more information, ask before the review.

The key things to focus on are:

When reviewing pull requests:

  • When you believe the pull request is ready to go into the core code master branch, go ahead and merge the pull request. As a member of the core committers group, you have the authority to merge into the core code base.

  • Once the request has been merged, if the branch attached to the pull request is in the archivesspace GitHub repository, please delete the branch using the delete button that should be provided in the pull request after merging.

 

At any time during the review of a pull request, please feel free to ping other members of the core committers group if you have questions or would like another set of eyes to look at the implementation in the pull request.