2018-01-08 Meeting notes

2018-01-08 Meeting notes

Date

Jan 8, 2018

Attendees

  • @Laney McGlohon (Unlicensed)

  • @Mark Cooper (Unlicensed)

  • @Former user (Deleted)

  • @Esha Datta (Unlicensed)

  • @William Mayo (Unlicensed)

  • @Alexander Duryee (Deactivated)

  • @Christine Kim

Absent

  • @Steven D. Majewski (Unlicensed)



Discussion Items

  • Alex and Miloche ASpace Testing Webinar - Webinars

  • Even though sometimes it is difficult to ignore other problems in the code being reviewed, in order to accept a pull request, just focus on the changes made and ensure that the issue at hand has been fixed. If, while reviewing a pull request, you see other issues that are unrelated to the current changes, put a new issue in GitHub so it can be worked on in the future. 

  • Fixing fragile/brittle tests 

    • sub group to work on them

    • where to start

  • Review

    • current pull requests

    • current GitHub issues

Action items

Laney fix permissions to merge
Dave and Alex to work together on getting the travis tests to pass