2019-11-21 Meeting notes
Date
2019-11-21
Attendees
@Laney McGlohon (Unlicensed)
@Mark Cooper (Unlicensed)
@Former user (Deleted)
@William Mayo (Unlicensed)
@Alexander Duryee (Deactivated)
@Steven D. Majewski (Unlicensed)
Greg Wiedeman
@Bria Lynn Parker (Unlicensed)
Jessica Crouch
Absent
Meeting information:
November 21, 2019 at 2pm EST
Discussion Items
Action items from last meeting
@Laney McGlohon (Unlicensed)
PR #1489 still outstanding - on Laney to test some more
@William Mayo (Unlicensed) update on the API Ad Hoc working group - API Ad Hoc Working Group
Developer Onboarding wiki pages for review and enhancement - Developer On-boarding
continue to look at utf8mb3 vs utf8mb4 implications
work on MariaDB recommendations
Steve is looking into oEmbed support
Stu provided Stanford's GitHub repo https://github.com/sul-dlss/sul-embed
Discussion topics
RuboCop - process and configuration
Decisions to make
Run RuboCop on entire code base or just require RuboCop for Pull Requests moving forward
Expect RuboCop run by pull request submitters or use Hound to automatically run for new or updated Pull Requests
Configuration settings different from out-of-the-box RuboCop (see attached lists and )
PRs merged since last meeting
1642 | ANW-758 (FOP fonts) | Laney McGlohon |
1652 | Removing empty test directories | Laney McGlohon |
1702 | Frontend Tests | Alex Duryee |
1703 | Manage Top Containers accessibility enhancements | Bria Parker |
1707 | ANW-864 laucher.rb - was looking for AppConfig[:frontend_cookie_secret_cookie_secret] | Mark Cooper |
1710 | Bump loofah from 2.3.0 to 2.3.1 | Laney McGlohon |
1711 | Docker Updates | Laney McGlohon |
1712 | Update gems | Laney McGlohon |
1714 | Ran RuboCop on all Gemfiles | Laney McGlohon |
Review current pull requests
1489 | switching on WheelEvent.deltaMode | Laney McGlohon |
1647 | Show an error message when the RDE hits a Sequel validation error | Steve Majewski |
1667 | Custom reports | Laney McGlohon |
1668 | make process for creating language notes more efficient | Laney McGlohon |
1684 | Add/update API docs | Dave Mayo |
1700 | recognise more utf8 encodings | Steve Majewski |
1705 | ANW-205: don't allow omitting required fields in RDE templates | Lora Woodford |
1708 | Improve performance by getting the json once instead of twice | Lora Woodford |
1709 | Always keep the display name when deduplicating non-authored names | Greg Wiedeman |
1713 | Fix for RDE templates created pre v2.7 | Alex Duryee |
Action items