2019-10-17 Meeting notes
Date
2019-10-17
Attendees
- Mark Cooper (Unlicensed)
- Former user (Deleted)
- William Mayo (Unlicensed)
- Alexander Duryee (Unlicensed)
- Steven D. Majewski (Unlicensed)
- Greg Wiedeman
- Bria Lynn Parker (Unlicensed)
- Jessica Crouch
Absent
Meeting information:
October 17, 2019 at 2pm EST
Discussion Items
- Action items from last meeting
- Laney McGlohon (Unlicensed)
- PR #1489 still outstanding - on Laney to test some more
- PR #1587- closed because decided this was best handled by modifying the PDF stylesheet
- Lora Woodford added issue #1625 to investigate removing parent_name column from DB
- William Mayo (Unlicensed) update on the API Ad Hoc working group - API Ad Hoc Working Group
- Laney McGlohon (Unlicensed)
- Discussion topics
- Developer Onboarding wiki pages for review and enhancement - /wiki/spaces/ADC/pages/894533891
- How to handle PRs that are a good start but are not complete
- Create feature branch in the core code repo with PR from forks
- Add WIP label to the beginning of the title of the PR when a reviewer thinks it needs more before merging to show that it is being worked on
- if it is enough to put into core code but can be enhanced later, go ahead and merge the PR and open a GitHub Issue with wht needs to happen next along with adding links in both directions to any corresponding Jira tickets
- Good litmus test for determining whether to put in a Jira ticket or a GitHub issue is whether it needs to go through the development prioritization group. If so, put in a Jira ticket, if not, put in a GitHub issue.
- Github Issue - Startup failure on fresh instance due to non-UTF-8 table, #1697. Reference https://mathiasbynens.be/notes/mysql-utf8mb4#column-index-length. https://github.com/archivesspace/archivesspace/pull/1700
- MariaDB support
- PRs merged since last meeting
| 1466 | ANW-669: bugfix for attributes in mixed content causing validation errors | Bria Parker, Christine diBella, and Laney McGlohon |
| 1544 | ANW-736: fix issues with reordering archival objects | Lora Woodford and Alex Duryee |
| 1587 | Anw 892 | Lora Woodford |
| 1617 | Catch exceptions and log activity | Lora Woodford |
| 1654 | Add new configuration option for mode the staff link on the PUI opens records in the staff interface | Steve Majewski |
- PRs closed since last meeting
| 1517 | ANW-874 |
| 1587 | closed because decided commas in addresses was best handled by modifying the PDF stylesheet |
| 1619 | closed because updating gems needs to be handled by a separate release |
- Review
- current pull requests
| 1488 | switching on WheelEvent.deltaMode | Laney McGlohon |
| 1642 | ANW-758 (FOP fonts) | Laney McGlohon |
| 1647 | Show an error message when the RDE hits a Sequel validation error | Steve Majewski |
| 1652 | Removing empty test directories | Laney McGlohon |
| 1667 | Custom reports | |
| 1668 | make process for creating language notes more efficient | |
| 1684 | Add/update API docs | Dave Mayo |
| 1700 | recognise more utf8 encodings |
Action items
continue to look at utf8mb3 vs utf8mb4 implications
- work on MariaDB recommendations
- Steve is looking into oEmbed support
- Stu provided Stanford's GitHub repo https://github.com/sul-dlss/sul-embed