2020-04-16 Meeting notes

10 min

Jessica/Everyone

How's everybody doin'?

5 min

Jessica

Another, more secure, zoom link going forward

Jessica will be sending a new calendar invite a more secure zoom appointment link. 

10 min 

Everyone

Old Business

• Developer Onboarding wiki pages for review and enhancement - Developer On-boarding

• Rubocop - Keep this on a the agenda but currently no activity

• Dave - Anything from the Ad Hoc API group

• Steve -investigating other database backends other than mysql

• Mark and Lora - Exploring front end tests and how to improve

  • Where do we want to document this?

    • In tech docs and the wiki?

• Decoupling tech docs from a release

• Open Calls

  • Can now be facilitated in slack but first will probably still be in Zoom

  • Online Forum participation (May 18-21)

Notes on testing:  

This can probably get removed as a standing item.  

The tests have been improved and are all working! 

Travis tests are still there but tests are also now run in GitHub actions.  Tests can be split for what GitHub calls "workflows," meaning front end, back end etc and you can elect to run a test on just one "workflow."

These tests should improve overall consistency.

By default the tests run heedlessly but you can configure this.

Tests work with Firefox and all but the front end test works with Chrome. 

You can monitor the status of your tests in slack.  The sidebar will turn green or red depending on if it passes or fails. 

Jessica will work to get this documented tech docs and will review the developer onboarding wiki pages to see what they say about testing and correct there. 

Takeaway: Tests can now be considered reliable and a pass should be considered required to move forward

10 min

Everyone

New Business/Open Discussion

• Upcoming release and code freeze

The next release is tentatively scheduled for mid-May so a code freeze is expected at the start of May.  

If you think you will have trouble getting your assigned PRs reviewed and merged by then, this is totally understandable, just let Lora know as soon as you can. 

3 min

Everyone

Closed Pull Requests since March 19, 2020
(is:pr is:closed base:master merged:>2020-02-20)

• Run GH actions on PR only

  #1859 by mark-cooper was merged 5 days ago

• Add github actions to run tests with mysql

  #1856 by mark-cooper was merged 12 days ago

• Update frontend selenium for firefox

  #1839 bymark-cooperwas merged22 days

• MySQL backend tests updated cont. 

  #1838 by mark-cooper was merged 29 days ago

• Fixes for backend tests run with MySQL 

  #1836 by mark-cooper was merged on Mar 13

• Improvements to Enumeration Model Migrate 

  #1834 by AustinTSchaffer was merged on Mar 13

• Make displaying search-in-collection form configurable option in other contexts 

  #1831 by andrew-morrison was merged 20 days ago

• Pass resource record to PUI PDF footer template 

  #1829 by andrew-morrison was merged 20 days ago

• ANW-953 heading tweak 

  #1828 by brianzelip was merged 29 days ago

• Modify the view published button in the staff interface toolbar 

  #1825 by andrew-morrison was merged 12 days ago

• Tasks 

  #1824 by mark-cooper was merged 19 days ago

• Create SECURITY.md 

  #1823 by Blake- was merged 19 days ago

• ANW-1048 and ANW-1052 required column fix 

  #1820 by brianzelip was merged on Mar 2

• Ensure alert popups retain "X" to close, but with screen reader labels 

  #1818 by lorawoodford was merged on Mar 6

• ANW-694: allow use of & characters in citations 

  #1816 by sem42198 was merged on Mar 2

• Fix for "Retrying include_theme_css". 

  #1814 by mark-cooper was merged on Feb 25

• ANW-1040 Replace saxon-xslt gem with saxon-rb 

  #1813 by fidothe was merged 22 days ago

• ANW-148: Remove OCLC search from LCNAF plugin 

  #1811 by lorawoodford was merged 27 days ago

• Option for preferences to set locale 

  #1810 by mark-cooper was merged 12 days ago

• Refactor login panel ANW-953 

  #1802 by brianzelip was merged on Mar 2 

• Add "nofollow" rel attribute to links in facets/filters in PUI 

  #1797 by andrew-morrison was merged on Feb 26

• ANW-1020. uniq_ao_pos index constraint violation fix 

  #1795 by dsteelma-umd was merged on Mar 3

• ANW-1018: Add language facet 

  #1792 by andrew-morrison was merged on Mar 6

• Remove code which adds a match-all clause to negated subqueries 

  #1791 by andrew-morrison was merged on Feb 20

• fix for json ld when dates of existence lacked a begin or end value i… 

      #1780 by fordmadox was merged 27 days ago

• ANW-1009: Allow narrowing of PUI search by multiple values in the same facet 

  #1778 by andrew-morrison was merged on Feb 28

• ANW-550 Add confirm modal to merge container profiles workflow 

  #1776 by brianzelip was merged on Feb 24

• Anw 462 

  #1764 by lorawoodford was merged 12 days ago

• Always keep the display name when deduplicating non-authorized names 

  #1709 by marktriggs was merged on Mar 11

• ANW-927: make process for creating language notes more efficient 

  #1668 by sem42198 was merged on Feb 28

Mark

Arcspc 658 for submission - title sort numeric-sensitive

#1854 opened 15 days ago by michael-lts 

Generalized table improvements to core 

#1844 opened 27 days ago by pobocks

ANW-257: Add hint to adding Assessment Attributes 

#1808 opened on Feb 17 by lorawoodford

Alex

ANW-805: Change logic for when dao/daogrp/daolink get "internal" audience attributes 

#1807 opened on Feb 17 by andrew-morrison

Steve

ANW-172: Add all dates to ao and do records h2

#1860 opened 5 days ago by lorawoodford

Date filter fixes

#1852 opened 19 days ago by andrew-morrison

Dave

Issue #393: Only use pagingation for calls going through handle_listing 

#1864 opened 2 minutes ago by lorawoodford

Issue #1384: Use correct method for classification_terms/parent endpoint 

#1867 opened 2 minutes ago by lorawoodford

Bria

ANW-292: Correct conflicting record error on authority id collision

#1857 opened 9 days ago by lorawoodford 

Change PUI container display page search results title ANW-867 

#1832 opened on Mar 10 by AustinTSchaffer

Greg

Lora

Updated API docs with general information section. API documentation

#1863 opened 13 hours ago by pobocks

Arcspc 658 for submission - title sort numeric-sensitive

#1854 opened 15 days ago by michael-lts

ANW-700 Add Related Accessions id to Resource edit mode

#1846 opened 24 days ago by brianzelip

ANW-172 Show all sub record dates in tree

#1845 opened 26 days ago by brianzelip • Changes requested

Generalized table improvements to core 

#1844 opened 27 days ago by pobocks 6 of 9

Fixes #1488 by switching on WheelEvent.deltaMode 

#1489 opened on Mar 20, 2019 by pobocks

5 min

Everyone

Our next meeting will be Thursday, May 21st at 1pm ET